[libvirt] [PATCH] qemu: domain: Properly lookup top of chain in qemuDomainGetStorageSourceByDevstr

Peter Krempa pkrempa at redhat.com
Wed Mar 29 15:05:01 UTC 2017


On Wed, Mar 29, 2017 at 10:01:14 -0500, Eric Blake wrote:
> On 03/29/2017 09:58 AM, Peter Krempa wrote:
> > When idx is 0 virStorageFileChainLookup returns the base (bottom) of the
> > backing chain rather than the top. This is expected by the callers of
> > qemuDomainGetStorageSourceByDevstr.
> > 
> > Add a special case for idx == 0
> > ---
> > With this you are not able to specify the top image of a disk when using
> > virDomainSetBlockThreshold in qemu.
> > 
> >  src/qemu/qemu_domain.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> ACK

Pushed; thanks for the quick review!

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170329/03cdc100/attachment-0001.sig>


More information about the libvir-list mailing list