[libvirt] [PATCH v2 8/11] hyperv: update wmi code generator.

[Neal Gompa]

On Thu, Mar 30, 2017 at 2:00 PM, Dawid Zamirski <dzamirski at datto.com> wrote:
> This patch updates the code generator that outputs C headers and code
> for WMI classes. It has been updated to handle multiple versions (or
> namespaces) of the same class which were introduced with Hyperv 2012+
> ---
>
> changes in v2:
>  * make it pass "make syntax-check"
>
>  src/hyperv/hyperv_wmi_generator.py | 407 ++++++++++++++++++++++++++-----------
>  1 file changed, 283 insertions(+), 124 deletions(-)
>  mode change 100755 => 100644 src/hyperv/hyperv_wmi_generator.py
>
> diff --git a/src/hyperv/hyperv_wmi_generator.py b/src/hyperv/hyperv_wmi_generator.py
> old mode 100755
> new mode 100644

Why are you changing the mode of the file?

> index 8c62882..21934fd
> --- a/src/hyperv/hyperv_wmi_generator.py
> +++ b/src/hyperv/hyperv_wmi_generator.py
> @@ -1,153 +1,308 @@
>  #!/usr/bin/env python
>
> -#
> -# hyperv_wmi_generator.py: generates most of the WMI type mapping code
> -#
> -# Copyright (C) 2011 Matthias Bolte <matthias.bolte at googlemail.com>
> -#
> -# This library is free software; you can redistribute it and/or
> -# modify it under the terms of the GNU Lesser General Public
> -# License as published by the Free Software Foundation; either
> -# version 2.1 of the License, or (at your option) any later version.
> -#
> -# This library is distributed in the hope that it will be useful,
> -# but WITHOUT ANY WARRANTY; without even the implied warranty of
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -# Lesser General Public License for more details.
> -#
> -# You should have received a copy of the GNU Lesser General Public
> -# License along with this library.  If not, see
> -# <http://www.gnu.org/licenses/>.
> -#
> -

Please put this back. It should not have been deleted.

Other than these two issues, this patch looks okay to me.

-- 
真実はいつも一つ！/ Always, there's only one truth!