[libvirt] [PATCH 1/2] virDomainDiskDefForeachPath: Prefer virStorageSourceIsLocalStorage

Martin Kletzander mkletzan at redhat.com
Fri Mar 31 11:48:20 UTC 2017


On Fri, Mar 31, 2017 at 01:13:50PM +0200, Michal Privoznik wrote:
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/conf/domain_conf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

ACK and safe for freeze.

>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>index 1b0a55b..01553b5 100644
>--- a/src/conf/domain_conf.c
>+++ b/src/conf/domain_conf.c
>@@ -25342,10 +25342,8 @@ virDomainDiskDefForeachPath(virDomainDiskDefPtr disk,
>     }
>
>     for (tmp = disk->src; tmp; tmp = tmp->backingStore) {
>-        int actualType = virStorageSourceGetActualType(tmp);
>         /* execute the callback only for local storage */
>-        if (actualType != VIR_STORAGE_TYPE_NETWORK &&
>-            actualType != VIR_STORAGE_TYPE_VOLUME &&
>+        if (virStorageSourceIsLocalStorage(tmp) &&
>             tmp->path) {
>             if (iter(disk, tmp->path, depth, opaque) < 0)
>                 goto cleanup;
>--
>2.10.2
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170331/8bebd5c6/attachment-0001.sig>


More information about the libvir-list mailing list