[libvirt] [PATCH] qemu: Fix persistent migration of transient domains

Pavel Hrdina phrdina at redhat.com
Tue May 2 16:49:47 UTC 2017

On Tue, May 02, 2017 at 06:32:19PM +0200, Jiri Denemark wrote:
> While fixing a bug with incorrectly freed memory in commit
> v3.1.0-399-g5498aa29a, I accidentally broke persistent migration of
> transient domains. Before adding qemuDomainDefCopy in the path, the code
> just took NULL from vm->newDef and used it as the persistent def, which
> resulted in no persistent XML being sent in the migration cookie. This
> scenario is perfectly valid and the destination correctly handles it by
> using the incoming live definition and storing it as the persistent one.
> After the mentioned commit libvirtd would just segfault in the described
> scenario.
> https://bugzilla.redhat.com/show_bug.cgi?id=1446205
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_migration.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170502/b536fed0/attachment-0001.sig>

More information about the libvir-list mailing list