[libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place

[Ján Tomko]

On Fri, May 12, 2017 at 04:00:06PM +0200, Martin Kletzander wrote:
>On Fri, May 12, 2017 at 03:23:27PM +0200, Ján Tomko wrote:
>>On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
>>>I like to use it that way and every time I try running it I just
>>>instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
>>>
>>>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>>>---
>>> tests/test-wrap-argv.pl | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>diff --git a/tests/test-wrap-argv.pl b/tests/test-wrap-argv.pl
>>>index f0d3c0ba2d10..7867e9d7194e 100755
>>>--- a/tests/test-wrap-argv.pl
>>>+++ b/tests/test-wrap-argv.pl
>>>@@ -31,7 +31,7 @@
>>> $in_place = 0;
>>> $check = 0;
>>>
>>>-if (@ARGV[0] eq "--in-place") {
>>>+if (@ARGV[0] eq "--in-place" or @ARGV[0] eq "-i") {
>>>     $in_place = 1;
>>>     shift @ARGV;
>>> } elsif (@ARGV[0] eq "--check") {
>>
>>or @ARGV[0] eq "-c" maybe?
>>
>
>Does that mean ACK with that added as well?

Hopefully P.H.'s R-b served as an ACK.

It was just a thought I had and liked so much I had to share it with the
world.

Feel free to include it in the commit or disregard it completely.

Have a nice weekend.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170512/53308d3c/attachment-0001.sig>