[libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place

Martin Kletzander mkletzan at redhat.com
Fri May 12 14:32:15 UTC 2017


On Fri, May 12, 2017 at 04:12:06PM +0200, Pavel Hrdina wrote:
>On Fri, May 12, 2017 at 03:59:46PM +0200, Martin Kletzander wrote:
>> On Fri, May 12, 2017 at 03:15:58PM +0200, Pavel Hrdina wrote:
>> >On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
>> >> I like to use it that way and every time I try running it I just
>> >> instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
>> >>
>> >> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> >> ---
>> >>  tests/test-wrap-argv.pl | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> >Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
>>
>> Does that mean ACK?
>
>https://www.kernel.org/doc/html/latest/process/submitting-patches.html#reviewer-s-statement-of-oversight
>
>s/kernel/libvirt/ for the text
>

Honestly, I didn't know there is also definition of other -by:'s, I
probably read those docs back when there was just Signed-of-by
definition.  So thanks for new info ;)  Anyway, do we have some
documentation about libvirt using these tags as well?  I only remember
talking about S-o-b being "preferred", not even required.  Any news on
that front?  BTW: I'll push this in a while.

>Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170512/8dac7377/attachment-0001.sig>


More information about the libvir-list mailing list