[libvirt] [PATCH 05/10] apparmor, virt-aa-helper: Explicit denies for host devices

[Guido Günther]

On Mon, May 15, 2017 at 03:23:14PM +0200, Stefan Bader wrote:
> From: Felix Geyer <fgeyer at debian.org>
> 
> Add explicit denies for disk devices to avoid cluttering dmesg with
> (acceptable) denials.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
> Signed-off-by: Stefan Bader <stefan.bader at canonical.com>
> ---
>  examples/apparmor/usr.lib.libvirt.virt-aa-helper | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> index ee53c2c..7804b72 100644
> --- a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> +++ b/examples/apparmor/usr.lib.libvirt.virt-aa-helper
> @@ -21,6 +21,11 @@ profile virt-aa-helper /usr/{lib,lib64}/libvirt/virt-aa-helper {
>    # for hostdev
>    /sys/devices/ r,
>    /sys/devices/** r,
> +  deny /dev/sd* r,
> +  deny /dev/vd* r,
> +  deny /dev/dm-* r,
> +  deny /dev/mapper/ r,
> +  deny /dev/mapper/* r,
>  
>    /usr/{lib,lib64}/libvirt/virt-aa-helper mr,
>    /{usr/,}sbin/apparmor_parser Ux,
> -- 
> 2.7.4

ACK (shipped in a similar form in Debian already).
 -- Guido