[libvirt] [PATCH python] Fix virStream.sendAll for Python 3

Martin Kletzander mkletzan at redhat.com
Wed May 17 07:12:01 UTC 2017


On Fri, May 05, 2017 at 04:39:34PM +0200, Xavier Fernandez wrote:
>In Python 3, if the file is open in binary mode, ``got`` will end up
>being equal to b"" and b"" != "" in Python 3.
>---
> libvirt-override-virStream.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Makes sense, I also stumbled upon something similar.  ACK and I will
push this in a while, thanks for the patch.  I'll reword the commit
message a tiny bit.

>diff --git a/libvirt-override-virStream.py b/libvirt-override-virStream.py
>index c328154..2e77cc7 100644
>--- a/libvirt-override-virStream.py
>+++ b/libvirt-override-virStream.py
>@@ -83,7 +83,7 @@
>                     pass
>                 raise e
>
>-            if got == "":
>+            if not got:
>                 break
>
>             ret = self.send(got)
>--
>2.12.2
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170517/d8506565/attachment-0001.sig>


More information about the libvir-list mailing list