[libvirt] [PATCH] qemu: monitor: Don't bother extracting vCPU halted state in text monitor

Ján Tomko jtomko at redhat.com
Thu May 18 11:53:55 UTC 2017

On Thu, May 18, 2017 at 01:47:03PM +0200, Peter Krempa wrote:
>The code causes the 'offset' variable to be overwritten (possibly with
>NULL if neither of the vCPUs is halted) which causes a crash since the
>variable is still used after that part.
>Additionally there's a bug, since strstr() would look up the '(halted)'
>string in the whole string rather than just the currently processed line
>the returned data is completely bogus.
>Rather than switching to single line parsing let's remove the code
>altogether since it has a commonly used JSON monitor alternative and
>the data itself is not very useful to report.
>The code was introduced in commit cc5e695bde
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1452106
> src/qemu/qemu_monitor_text.c | 6 ------
> 1 file changed, 6 deletions(-)


When will we able to kill the whole file?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170518/8dc709b6/attachment-0001.sig>

More information about the libvir-list mailing list