[libvirt] [PATCH 04/13] nodedev: Move node_device_linux_sysfs from node_driver to conf

Bjoern Walk bwalk at linux.vnet.ibm.com
Tue May 23 08:13:30 UTC 2017


John Ferlan <jferlan at redhat.com> [2017-05-19, 09:08AM -0400]:
>Move the whole file from src/node_device into src/conf and rename the
>API's to have the "virNodeDevice" prefix.
>
>Signed-off-by: John Ferlan <jferlan at redhat.com>
>---
> src/Makefile.am                                    |  8 ++++----
> .../node_device_linux_sysfs.c                      | 24 ++++++++++------------
> .../node_device_linux_sysfs.h                      |  9 +++++---
> src/libvirt_private.syms                           |  5 +++++
> src/node_device/node_device_driver.c               |  8 ++++----
> src/node_device/node_device_hal.c                  |  4 ++--
> src/node_device/node_device_udev.c                 |  4 ++--
> 7 files changed, 34 insertions(+), 28 deletions(-)
> rename src/{node_device => conf}/node_device_linux_sysfs.c (89%)
> rename src/{node_device => conf}/node_device_linux_sysfs.h (82%)
>

What's the reasoning for this move? It somehow doesn't feel right and it
will make backports harder.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 896 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170523/a92d6d2e/attachment-0001.sig>


More information about the libvir-list mailing list