[libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

Martin Kletzander mkletzan at redhat.com
Wed May 24 10:58:36 UTC 2017

On Wed, May 24, 2017 at 12:54:26PM +0200, Peter Krempa wrote:
>On Wed, May 24, 2017 at 12:49:58 +0200, Michal Privoznik wrote:
>> On 05/24/2017 12:32 PM, Martin Kletzander wrote:
>> > On Tue, May 23, 2017 at 05:29:52PM +0200, Peter Krempa wrote:
>> >> On Tue, May 23, 2017 at 17:19:53 +0200, Martin Kletzander wrote:
>> >>> On Tue, May 23, 2017 at 05:07:40PM +0200, Michal Privoznik wrote:
>> >> Also compared to a full fragmentation of the returned data, this would
>> >> result into a worst-case-scenario memory usage of MAX_SIZE *
>> >> NVMS_QUERIED_IN_ORIGINAL_CALL, when compared to an unbounded memory use
>> >> of the full fragmentation approach.
>> >
>> > If I get what you are saying, then the same would happen if the mgmt app
>> > (or client) implemented it themselves.  We would basically just provide
>> > the guessing logic.
>> That's quite exact. I mean the word 'guessing'. We can't really provide
>> reliable way of dealing with what you're suggesting (unless we cut the
>> limit really small) nor we can guarantee atomicity. Therefore I think it
>> would be a waste of time to work on this. Yes, it can be done, but the
>> benefits are pretty small IMO.
>Yes, I agree. Therefore I opted to add the notice for this API.

I was just discussing an idea on a side.  I'm still OK with the notice.
I'm not sure if that's exactly what Dan had in mind, though.

>libvir-list mailing list
>libvir-list at redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170524/8a9a5d72/attachment-0001.sig>

More information about the libvir-list mailing list