[libvirt] [PATCH v2] Regression: Report correct CPUs present on executing virsh nodecpumap

[Nitesh Konkar]

On Thu, May 25, 2017 at 2:14 PM, Ján Tomko <jtomko at redhat.com> wrote:

> On Thu, May 25, 2017 at 02:04:16PM +0530, Nitesh Konkar wrote:
>
>> On executing the virsh nodecpumap command, the number
>> of CPUs present was shown as (last cpu online id + 1). This
>> patch fixes the issue by reporting the current number of
>> CPUs present.
>>
>> Signed-off-by: Nitesh Konkar <nitkon12 at linux.vnet.ibm.com>
>> ---
>> src/util/virhostcpu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
>> index aa9cfeac2..6d7e8b4f4 100644
>> --- a/src/util/virhostcpu.c
>> +++ b/src/util/virhostcpu.c
>> @@ -1093,7 +1093,7 @@ virHostCPUGetMap(unsigned char **cpumap,
>>     if (online)
>>         *online = virBitmapCountBits(cpus);
>>
>> -    ret = virBitmapSize(cpus);
>> +    ret = virHostCPUParseCountLinux();
>>
>
> This should be virHostCPUGetCount, just like we have a few lines above.
> That way the function has a chance of working on FreeBSD too.
>
Yea agree. I missed out on checking for FreeBSD.
Nitesh.

>
> Jan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170525/de2e04c7/attachment-0001.htm>