[libvirt] [PATCH v2 00/14] Work towards making virNodeDeviceObjPtr private

John Ferlan jferlan at redhat.com
Thu May 25 19:56:57 UTC 2017

v1: https://www.redhat.com/archives/libvir-list/2017-May/msg00718.html

Changes since v1:

 * Adjusted the title of cover letter to more appropriately match what's
   being done.

 * Added new patch 3 to cover issues I've noted in recent code reviews
   where additions to virNodeDevCapType may not be properly 'covered'
   in the virNodeDeviceObjHasCap and virNodeDeviceCapMatch helpers. With
   the switch, it'll be forced.

 * Removed former patch 4 - I'll deal with it later.

 * Added patch 13

 * Patch 14 is the old patch 13o

There's another 8 or so patches waiting to go, but the "next" one in the
series depends on other things currently on list waiting for review.

John Ferlan (14):
  test: Adjust cleanup/error paths for nodedev test APIs
  nodedev: Fix locking in virNodeDeviceObjRemove
  nodedev: Need to check for vport capable scsi_host for vHBA searches
  nodedev: Use switch for virNodeDeviceObjHasCap and
  nodedev: Use common naming for virnodedeviceobj
  nodedev: Cleanup driver code and prototypes
  nodedev: Alter param to nodeDeviceUpdateDriverName
  nodedev: Alter param to nodeDeviceUpdateCaps
  nodedev: Create helper for finding by name in driver
  nodedev: Use consistent names for driver variables
  nodedev: Introduce virNodeDeviceObjGetDef
  nodedev: Remove privateData from virNodeDeviceObj
  nodedev: Pass @def by reference to create/assign object
  nodedev: Introduce virNodeDeviceObjNew

 src/conf/node_device_conf.h          |   2 -
 src/conf/virnodedeviceobj.c          | 252 ++++++++++++++++-----------
 src/conf/virnodedeviceobj.h          |   4 +-
 src/libvirt_private.syms             |   1 +
 src/node_device/node_device_driver.c | 233 ++++++++++++-------------
 src/node_device/node_device_driver.h |  93 +++++++---
 src/node_device/node_device_hal.c    |  56 +++---
 src/node_device/node_device_udev.c   | 321 ++++++++++++++++++++---------------
 src/test/test_driver.c               | 118 +++++++------
 9 files changed, 609 insertions(+), 471 deletions(-)


More information about the libvir-list mailing list