[libvirt] [PATCH v2 02/14] nodedev: Fix locking in virNodeDeviceObjRemove

Peter Krempa pkrempa at redhat.com
Fri May 26 06:57:29 UTC 2017


On Thu, May 25, 2017 at 15:56:59 -0400, John Ferlan wrote:
> The current mechanism doesn't lock each element in devs->objs as it's
> looking at it, rather it keeps locking/unlocking the passed element for
> which the removal is being attempted.  Fix things to lock each element
> as we're looking at them.

Since you are comparing only the pointer of the item locking it is
really not necessary.

Any other justification for this change?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170526/f13489fd/attachment-0001.sig>


More information about the libvir-list mailing list