[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 19/38] RPC: Introduce virNetStreamSkip




On 04/20/2017 06:01 AM, Michal Privoznik wrote:
> This is going to be RPC representation for virStreamSkip.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/rpc/virnetprotocol.x   | 4 ++++
>  src/virnetprotocol-structs | 3 +++
>  2 files changed, 7 insertions(+)
> 

As you mentioned earlier - a place no one really wants to touch. I'm
flying blind...

If there's a @flags for the Skip API as I questioned earlier, I assume
this structure would need similar adjustment.

Seems reasonable to me based on what (little) I understand, so ACK, but
probably need to let the other discussion conclude regarding arguments
before adjusting.

John

> diff --git a/src/rpc/virnetprotocol.x b/src/rpc/virnetprotocol.x
> index 9ce33b0..3623588 100644
> --- a/src/rpc/virnetprotocol.x
> +++ b/src/rpc/virnetprotocol.x
> @@ -236,3 +236,7 @@ struct virNetMessageError {
>      int int2;
>      virNetMessageNetwork net; /* unused */
>  };
> +
> +struct virNetStreamSkip {
> +    unsigned hyper length;
> +};
> diff --git a/src/virnetprotocol-structs b/src/virnetprotocol-structs
> index af4526c..a8cc603 100644
> --- a/src/virnetprotocol-structs
> +++ b/src/virnetprotocol-structs
> @@ -42,3 +42,6 @@ struct virNetMessageError {
>          int                        int2;
>          virNetMessageNetwork       net;
>  };
> +struct virNetStreamSkip {
> +        uint64_t                   length;
> +};
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]