[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH go-xml] remove superfluous state & omitempty entries



On Mon, Apr 24, 2017 at 12:09:15PM -0700, Ryan Goodfellow wrote:
> This commit removes the superfluous state and omit entries from my last
> commit. It factors the 'state' data member into a DomainFeatureState
> struct and only uses that struct where necessary e.g. HyperV features
> as well as a few top level features such as PMU, HAP etc. The HyperV
> suffix has also been added to features that are specific to
> HyperV.
> ---
>  domain.go      | 62 +++++++++++++++++++++++++++++-----------------------------
>  domain_test.go | 26 +++++++++++++-----------
>  2 files changed, 46 insertions(+), 42 deletions(-)

Ok, with these changes the result looks ok, so I've squashed this into
your previous patch and pushed.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]