[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 1/6] conf: add <ioapic driver> to <features>




On 05/03/2017 10:05 AM, Ján Tomko wrote:
> Add a new <ioapic> element with a driver attribute.
> 
> Possible values are qemu and kvm. With 'qemu', the I/O
> APIC can be put in the userspace even for KVM domains.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1427005
> ---
>  docs/formatdomain.html.in                          |  8 ++++++
>  docs/schemas/domaincommon.rng                      | 15 ++++++++++
>  src/conf/domain_conf.c                             | 33 +++++++++++++++++++++-
>  src/conf/domain_conf.h                             | 11 ++++++++
>  .../qemuxml2argv-intel-iommu-ioapic.xml            | 29 +++++++++++++++++++
>  .../qemuxml2xmlout-intel-iommu-ioapic.xml          |  1 +
>  tests/qemuxml2xmltest.c                            |  1 +
>  7 files changed, 97 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-ioapic.xml
>  create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-intel-iommu-ioapic.xml
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 8c884f4..6669e71 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -1678,6 +1678,7 @@
>    &lt;/kvm&gt;
>    &lt;pvspinlock state='on'/&gt;
>    &lt;gic version='2'/&gt;
> +  &lt;ioapic driver='qemu'/&gt;
>  
>  &lt;/features&gt;
>  ...</pre>
> @@ -1839,6 +1840,13 @@
>            for hypervisor to decide.
>            <span class="since">Since 2.1.0</span>
>        </dd>
> +      <dt><code>ioapic</code></dt>
> +      <dd>Tune the I/O APIC. Possible values for the
> +          <code>driver</code> attribute are:
> +          <code>kvm</code> (default for KVM domains)
> +          and <code>qemu</code> which puts I/O APIC in userspace.

s/./which is also known as a split I/O APIC mode.

> +          <span class="since">Since 3.4.0</span> (KVM only)

should this be QEMU/KVM like patch 3 ?

> +      </dd>
>      </dl>
>  
>      <h3><a name="elementsTime">Time keeping</a></h3>

[...]

ACK w/ slight adjustments.

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]