[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] configure: enforce presence of python for build



  Daniel P. Berrange wrote:

> The API docs extractor, ESX code generator and keycodemapdb tools
> rely on python. Historically every platform that this present, but
> with switch to Python3 by default, we're increasingly seeing
> installs without a /usr/bin/python.
> 
> This tightens up the check during configure, so it exits immediately
> if python is missing, rather than leaving an empty $(PYTHON) make
> variable which leads to more obscure errors later.
> 
> Also add it as a build dep for Mingw, since Fedora build roots no
> longer get python2 by default. This was not previously a major
> problem, since both ESX & API generated files were included in
> EXTRA_DIST, but the keycodemapdb generated files are not, so we
> require python all the time now.

I've just spotted the similar issue when building FreeBSD port, so this
changes makes perfect sense to me, ACK.

> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  configure.ac          | 5 ++++-
>  mingw-libvirt.spec.in | 1 +
>  2 files changed, 5 insertions(+), 1 deletion(-)

Roman Bogorodskiy

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]