[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] Add support for CPU cache specification



On Tue, Apr 25, 2017 at 08:48:44PM +0200, Jiri Denemark wrote:
> This patch introduces
> 
>     <cache level='N' mode='emulate'/>
>     <cache mode='passthrough'/>
>     <cache mode='disable'/>
> 
> sub element of /domain/cpu. Currently only a single <cache> element is
> allowed.
> 
> Signed-off-by: Jiri Denemark <jdenemar redhat com>

> ---
>  docs/formatdomain.html.in                          | 35 ++++++++++++
>  docs/schemas/cputypes.rng                          | 21 ++++++++
>  docs/schemas/domaincommon.rng                      |  3 ++
>  src/conf/cpu_conf.c                                | 62 ++++++++++++++++++++++

I could be mistake, but I didn't see any additions to cpu_conf.c
to validate CPU cache compatibility. ie nothing seems to prevent
you changing the cache XML when doing migration, which will lead
to badness....


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]