[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 1/6] conf: add <ioapic driver> to <features>



On Wed, 2017-05-03 at 16:05 +0200, Ján Tomko wrote:
> Add a new <ioapic> element with a driver attribute.
> 
> Possible values are qemu and kvm. With 'qemu', the I/O
> APIC can be put in the userspace even for KVM domains.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1427005
> ---
>  docs/formatdomain.html.in                          |  8 ++++++
>  docs/schemas/domaincommon.rng                      | 15 ++++++++++
>  src/conf/domain_conf.c                             | 33 +++++++++++++++++++++-
>  src/conf/domain_conf.h                             | 11 ++++++++
>  .../qemuxml2argv-intel-iommu-ioapic.xml            | 29 +++++++++++++++++++
>  .../qemuxml2xmlout-intel-iommu-ioapic.xml          |  1 +
>  tests/qemuxml2xmltest.c                            |  1 +
>  7 files changed, 97 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-ioapic.xml
>  create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-intel-iommu-ioapic.xml

Please make sure that only x86 guests can use the <ioapic/>
feature, and all other guests get an error instead.

Also I didn't check whether this is the case already, but
the feature should be advertised the same way <apic/> is,
and in particular it should show up in the capabilities XML.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]