[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] Add support for CPU cache specification



On Mon, May 08, 2017 at 15:37:24 +0100, Daniel P. Berrange wrote:
> On Tue, Apr 25, 2017 at 08:48:44PM +0200, Jiri Denemark wrote:
> > This patch introduces
> > 
> >     <cache level='N' mode='emulate'/>
> >     <cache mode='passthrough'/>
> >     <cache mode='disable'/>
> > 
> > sub element of /domain/cpu. Currently only a single <cache> element is
> > allowed.
> > 
> > Signed-off-by: Jiri Denemark <jdenemar redhat com>
> 
> > ---
> >  docs/formatdomain.html.in                          | 35 ++++++++++++
> >  docs/schemas/cputypes.rng                          | 21 ++++++++
> >  docs/schemas/domaincommon.rng                      |  3 ++
> >  src/conf/cpu_conf.c                                | 62 ++++++++++++++++++++++
> 
> I could be mistake, but I didn't see any additions to cpu_conf.c
> to validate CPU cache compatibility. ie nothing seems to prevent
> you changing the cache XML when doing migration, which will lead
> to badness....

Oh yeah, thanks for noticing this. I've just sent the fix:
https://www.redhat.com/archives/libvir-list/2017-May/msg00238.html

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]