[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH REBASE 06/10] conf: backup: add backup xml definition



On Fri, May 05, 2017 at 09:22:27AM +0300, Nikolay Shirokovskiy wrote:
> Backup xml description is like this:
> 
> <domainbackup>
>   <name>backup name</name>
>   <disk type="file" name="sda">
>     <target file="/path/to/backup/file.qcow2" format="qcow2"/>
>   </disk>
> </domainbackup>
> 
> - <name> element is optional.
> 
> - disk @type attribute is optional, default to 'file'. Valid
>   values are 'file', 'block', 'dir', 'network', 'volume' just
>   as usual for specifing domain disk sources. It specifies
>   backup <target> type.
> 
> - <target> element has same attributes and its values as
>   <source> element in domain disk description.
> 
> - target @format attribute is optional. If it is not specified
>   then hypervisor will choose format by its default rule
>   (for qemu it same format as disk to be backed up).
> 
> Elements that are not explicitly mentioned as optional are
> mandatory. Current description does not support implicitly
> specified disks to be backed up like snapshot xml description
> for example.
> ---
>  po/POTFILES.in           |   1 +
>  src/Makefile.am          |   1 +
>  src/conf/backup_conf.c   | 267 +++++++++++++++++++++++++++++++++++++++++++++++
>  src/conf/backup_conf.h   |  65 ++++++++++++
>  src/libvirt_private.syms |   6 ++
>  src/qemu/qemu_conf.h     |   1 +


This needs to have docs/schemas/domainbackup.rng file added, as
well as docs/formatdomainbackup.html.in


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]