[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't inline virStringTrimOptionalNewline



On Wed, May 10, 2017 at 11:12:00AM +0200, Martin Kletzander wrote:
> On Wed, May 10, 2017 at 09:26:18AM +0100, Daniel P. Berrange wrote:
> > GCC complains that inlining virStringTrimOptionalNewline is not
> > likely on some platforms:
> > 
> >  cc1: warnings being treated as errors
> >  ../../src/util/virfile.c: In function 'virFileReadValueBitmap':
> >  ../../src/util/virstring.h:292: error: inlining failed in call to 'virStringTrimOptionalNewline': call is unlikely and code size would grow [-Winline]
> >  ../../src/util/virfile.c:3987: error: called from here [-Winline]
> > 
> > Inlining this function is not going to be a measurable performance
> > benefit either, since the time required to execute it is going to
> > be dominated by running of strlen() over the string, not by the
> > function call overhead.
> > 
> 
> Oh, definitely.  Just out of curiosity, though; what platform does this
> happen on?

I saw it fail on centos6 in CI

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]