[libvirt] [PATCH 2/2] qemu: driver: Fix usage of qemuOpenFile

Ján Tomko jtomko at redhat.com
Wed May 10 12:36:54 UTC 2017


On Wed, May 10, 2017 at 02:18:33PM +0200, Peter Krempa wrote:
>The function returns -errno on failure, not only -1. This broken usage
>was introduced by commit 732af77cce.

Actually, that was commit b4a40dd92dc7e6f110b13f2353cb5343d1147227

I am unsure why this function should return -errno since no caller
cares.

>---
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

ACK series if you fix the usage in qemuDomainBlockPeek as well.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170510/ef85b37e/attachment-0001.sig>


More information about the libvir-list mailing list