[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: driver: Fix usage of qemuOpenFile



On Wed, May 10, 2017 at 02:18:33PM +0200, Peter Krempa wrote:
The function returns -errno on failure, not only -1. This broken usage
was introduced by commit 732af77cce.

Actually, that was commit b4a40dd92dc7e6f110b13f2353cb5343d1147227

I am unsure why this function should return -errno since no caller
cares.

---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


ACK series if you fix the usage in qemuDomainBlockPeek as well.

Jan

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]