[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-php PATCH 0/2] implement a few network API bindings



On 05/10/2017 11:31 PM, Neal Gompa wrote:
> On Mon, May 8, 2017 at 11:43 AM, Dawid Zamirski <dzamirski datto com> wrote:
>> Hello,
>>
>> The followinig two patches add a few useful API bindings for dealing
>> with libvirt networks:
>>
>> * virConnectListAllNetworks - allows for better control when filtering
>>   and returns array of handles to virNetworkPtr which can then be used
>>   to get other info for each network such as name, uuid, autostart etc.
>> * virNetworkGetUUIDString, virNetworkGetUUID, virNetworkGetName to be
>>   able to easily get said info when working with virNetworkPtr handles.
>>
>> Dawid Zamirski (2):
>>   implement binding for virConnectListAllNetworks.
>>   implement additional network functions.
>>
>>  src/libvirt-php.c | 149 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  src/libvirt-php.h |   4 ++
>>  2 files changed, 153 insertions(+)
>>
> 
> @Dawid:
> This patch series looks okay to me, fwiw.

Agreed, pushed.

> 
> @Michal:
> After merging these patches in, could you please make a new release?
> It's been a bit over a year, and there's been quite a few changes
> since last year's release. I'd like to pull in the release and push it
> out in Fedora and EPEL 7.

Sure. Let me do that.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]