[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Enable Travis CI build status icon



On Thu, May 11, 2017 at 02:35:12PM +0100, Daniel P. Berrange wrote:
On Thu, May 11, 2017 at 03:30:00PM +0200, Martin Kletzander wrote:
On Tue, Apr 18, 2017 at 02:39:28PM -0300, Claudio André wrote:
> Using GitHub libvirt site, it is possible to show Travis's fancy icon of the current build status. It highlights the QA process.

I like seeing the icon there.  It's very quick reference that serves the
purpose.

There's no need for a cover letter when sending one patch.

> ---
> README.md | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 README.md
>
> diff --git a/README.md b/README.md
> new file mode 100644
> index 0000000..a609286
> --- /dev/null
> +++ b/README.md
> @@ -0,0 +1,12 @@
> +## *LibVirt: the virtualization API* [![Build Status](https://travis-ci.org/libvirt/libvirt.svg)](https://travis-ci.org/libvirt/libvirt)
> +

I don't care about the number of (sub-)s in 'sub-heading', but why
making it italic as well?  ACK without the italic.  Will push this in a
while.  Thanks.

> +  Libvirt is a C toolkit to interact with the virtualization capabilities
> +of recent versions of Linux (and other OSes). It is free software
> +available under the GNU Lesser General Public License. Virtualization of
> +the Linux Operating System means the ability to run multiple instances of
> +Operating Systems concurrently on a single hardware system where the basic
> +resources are driven by a Linux instance. The library aim at providing
> +long term stable C API initially for the Xen paravirtualization but
> +should be able to integrate other virtualization mechanisms if needed.
> +
> +Daniel Veillard <veillard redhat com>

This just duplicates the existing README file content. If we're going todo
this we should just make README a symlink to README.md or vica-verca.


What space would we save by that?  I don't think people would be
confused by the icon text in the readme, so I don't really care.  So I
can add one more patch after this or squash it in:

diff --git i/README w/README
deleted file mode 100644
index 3d5167dfe1e1..000000000000
--- i/README
+++ /dev/null
@@ -1,13 +0,0 @@
-
-         LibVirt : simple API for virtualization
-
-  Libvirt is a C toolkit to interact with the virtualization capabilities
-of recent versions of Linux (and other OSes). It is free software
-available under the GNU Lesser General Public License. Virtualization of
-the Linux Operating System means the ability to run multiple instances of
-Operating Systems concurrently on a single hardware system where the basic
-resources are driven by a Linux instance. The library aim at providing
-long term stable C API initially for the Xen paravirtualization but
-should be able to integrate other virtualization mechanisms if needed.
-
-Daniel Veillard <veillard redhat com>
diff --git i/README w/README
new file mode 120000
index 000000000000..42061c01a1c7
--- /dev/null
+++ w/README
@@ -0,0 +1 @@
+README.md
\ No newline at end of file
--

Regards,
Daniel
--
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]