[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH python] Fix virStream.sendAll for Python 3

Great !
Thanks for the merge and your work :)


On Wed, May 17, 2017 at 9:12 AM, Martin Kletzander <mkletzan redhat com> wrote:
On Fri, May 05, 2017 at 04:39:34PM +0200, Xavier Fernandez wrote:
In Python 3, if the file is open in binary mode, ``got`` will end up
being equal to b"" and b"" != "" in Python 3.
libvirt-override-virStream.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Makes sense, I also stumbled upon something similar.  ACK and I will
push this in a while, thanks for the patch.  I'll reword the commit
message a tiny bit.

diff --git a/libvirt-override-virStream.py b/libvirt-override-virStream.py
index c328154..2e77cc7 100644
--- a/libvirt-override-virStream.py
+++ b/libvirt-override-virStream.py
@@ -83,7 +83,7 @@
                raise e

-            if got == "":
+            if not got:

            ret = self.send(got)

libvir-list mailing list
libvir-list redhat com

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]