[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 1/6] mdev: Pass a uuidstr rather than an mdev object to some util functions




On 05/15/2017 08:10 AM, Erik Skultety wrote:
> Namely, this patch is about virMediatedDeviceGetIOMMUGroup{Dev,Num}
> functions. There's no compelling reason why these functions should take
> an object, on the contrary, having to create an object every time one
> needs to query the IOMMU group number, discarding the object afterwards,
> seems odd.
> 
> Signed-off-by: Erik Skultety <eskultet redhat com>
> ---
>  src/qemu/qemu_domain.c           |  8 +-------
>  src/security/security_apparmor.c | 10 +---------
>  src/security/security_dac.c      | 20 ++------------------
>  src/security/security_selinux.c  | 20 ++------------------
>  src/util/virmdev.c               | 21 +++++++++++++--------
>  src/util/virmdev.h               |  4 ++--
>  6 files changed, 21 insertions(+), 62 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]