[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/8] interface: Use virInterfaceDefPtr rather than deref from virInterfaceObjPtr



On 04/26/2017 12:36 AM, John Ferlan wrote:
> We're about to make the obj much more private, so make it easier to
> see future changes which will require accessors for the obj->def
> 
> This also includes modifying some interfaces->objs[i]->X references to be
> obj = interfaces->objs[i]; and then def = obj->def
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/conf/virinterfaceobj.c | 33 +++++++++++++++++++++------------
>  src/test/test_driver.c     | 12 +++++++++---
>  2 files changed, 30 insertions(+), 15 deletions(-)
> 
> diff --git a/src/conf/virinterfaceobj.c b/src/conf/virinterfaceobj.c
> index 62c3735..36131af 100644
> --- a/src/conf/virinterfaceobj.c
> +++ b/src/conf/virinterfaceobj.c
> @@ -55,7 +55,6 @@ virInterfaceObjFree(virInterfaceObjPtr obj)
>  {
>      if (!obj)
>          return;
> -
>      virInterfaceDefFree(obj->def);
>      virMutexDestroy(&obj->lock);
>      VIR_FREE(obj);

This looks spurious.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]