[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] test: fixing variable names for test suite inside configure.ac.



Thanks Michal,

There are other variables with the same behaviour. ACL for example.
I will check everything and submit a new bugfix.

2017-05-22 1:33 GMT-03:00 Michal Privoznik <mprivozn redhat com>:
> On 05/20/2017 04:53 PM, Julio Faracco wrote:
>> Both variables for gcov and oom have wrong names inside configure.ac.
>> For this reason, the Test Suite configuration is not showing the current
>> configuration.
>>
>> Before patching:
>> configure:    windres: no
>> configure:
>> configure: Test suite
>> configure:
>> configure:          Coverage:
>> configure:         Alloc OOM:
>> configure:
>> configure: Miscellaneous
>>
>> After patching (using --enable-test-coverage and --enable-test-oom):
>> configure:    windres: no
>> configure:
>> configure: Test suite
>> configure:
>> configure:          Coverage: yes
>> configure:         Alloc OOM: yes
>> configure:
>> configure: Miscellaneous
>>
>> Signed-off-by: Julio Faracco <jcfaracco gmail com>
>> ---
>>  configure.ac | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 2e60513..246f4e0 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1005,8 +1005,8 @@ LIBVIRT_WIN_RESULT_WINDRES
>>  AC_MSG_NOTICE([])
>>  AC_MSG_NOTICE([Test suite])
>>  AC_MSG_NOTICE([])
>> -AC_MSG_NOTICE([         Coverage: $enable_coverage])
>> -AC_MSG_NOTICE([        Alloc OOM: $enable_oom])
>> +AC_MSG_NOTICE([         Coverage: $enable_test_coverage])
>> +AC_MSG_NOTICE([        Alloc OOM: $enable_test_oom])
>>  AC_MSG_NOTICE([])
>>  AC_MSG_NOTICE([Miscellaneous])
>>  AC_MSG_NOTICE([])
>>
>
> Ah, nice catch. ACKed and pushed.
>
> Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]