[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-python][PATCH 0/4] Implement sparse streams



On Mon, May 22, 2017 at 03:33:21PM +0200, Michal Privoznik wrote:
On 05/22/2017 12:57 PM, Michal Privoznik wrote:
*** BLURB HERE ***

Michal Privoznik (4):
  Implement virStreamSendHole/virStreamRecvHole
  virStream: Introduce virStreamRecvFlags
  virStream: Introduce virStreamSparse{Recv,Send}All
  examples: Introduce sparsestream.py

 examples/sparsestream.py      | 119 ++++++++++++++++++++++++++++++++
 generator.py                  |   5 ++
 libvirt-override-virStream.py | 156 ++++++++++++++++++++++++++++++++++++++++++
 libvirt-override.c            | 102 +++++++++++++++++++++++++++
 4 files changed, 382 insertions(+)
 create mode 100755 examples/sparsestream.py


D'oh! I haven't had nose installed. Consider this squashed into respective commits:


And I considered this squashed in to them when doing the review.

diff --git i/sanitytest.py w/sanitytest.py
index 7183baa..deec200 100644
--- i/sanitytest.py
+++ w/sanitytest.py
@@ -167,7 +167,8 @@ for cname in wantfunctions:
    # These aren't functions, they're callback signatures
    if name in ["virConnectAuthCallbackPtr", "virConnectCloseFunc",
                "virStreamSinkFunc", "virStreamSourceFunc", "virStreamEventCallback",
-                "virEventHandleCallback", "virEventTimeoutCallback", "virFreeCallback"]:
+                "virEventHandleCallback", "virEventTimeoutCallback", "virFreeCallback",
+                "virStreamSinkHoleFunc", "virStreamSourceHoleFunc", "virStreamSourceSkipFunc"]:
        continue
    if name[0:21] == "virConnectDomainEvent" and name[-8:] == "Callback":
        continue
@@ -373,7 +374,8 @@ for name in sorted(finalklassmap):

    # These exist in C and exist in python, but we've got
    # a pure-python impl so don't check them
-    if name in ["virStreamRecvAll", "virStreamSendAll"]:
+    if name in ["virStreamRecvAll", "virStreamSendAll",
+            "virStreamSparseRecvAll", "virStreamSparseSendAll"]:
        continue

    try:

Michal

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]