[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: process: Clear priv->namespaces on VM shutdown



On Mon, May 22, 2017 at 15:04:58 +0200, Martin Kletzander wrote:
> On Mon, May 22, 2017 at 01:40:01PM +0200, Peter Krempa wrote:
> > Otherwise the private data entry would be kept across instances of the
> > same VM even if it's not configured to do so.
> > 
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1453142
> > ---
> > src/qemu/qemu_process.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> > 
> > diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> > index c19bd2925..ac17da668 100644
> > --- a/src/qemu/qemu_process.c
> > +++ b/src/qemu/qemu_process.c
> > @@ -6449,6 +6449,10 @@ void qemuProcessStop(virQEMUDriverPtr driver,
> >     /* clean up migration data */
> >     VIR_FREE(priv->migTLSAlias);
> > 
> > +    /* clear previously used namespaces */
> > +    virBitmapFree(priv->namespaces);
> > +    priv->namespaces = NULL;
> > +
> 
> Does this mean we can kill the call to qemuDomainDestroyNamespace() from
> qemuProcessHandleMonitorEOF() (and possibly the whole function)?

The comment there hints that it may be necessary in some cleanup cases,
so I did not remove it.

> 
> ACK either way, this should be cleaned up every time.

Thanks, there are no cleanup steps after that so clearing it is okay
either way.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]