[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers



On 05/24/2017 12:55 PM, Martin Kletzander wrote:
> <snip/>
> 
> No, this has nothing to do with RPC.  Let me "pseudocode" this:
> 
> 
> int
> virConnectGetAllDomainStats(virConnectPtr conn,
>                            ...,
>                            unsigned int flags)
> {
>    bool legacy = flags & VIR_CONNECT_GET_ALL_DOMAIN_STATS_OK_IF_NOT_ATOMIC;

The mere presence of the flags says we have a limit on RPC layer that
users need to pass in order to avoid it. And if we ever introduce the
flag, all users will use it in order to not having to care about it anymore.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]