[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] conf: add eim attribute to <iommu><driver>



On Thu, 2017-05-18 at 11:09 +0200, Ján Tomko wrote:
> Add an attribute to control extended interrupt mode.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1451282

[...]
> @@ -14184,6 +14184,14 @@ virDomainIOMMUDefParseXML(xmlNodePtr node,
>          }
>          iommu->caching_mode = val;
>      }

Add an empty line here, please.

> +    VIR_FREE(tmp);
> +    if ((tmp = virXPathString("string(./driver/@eim)", ctxt))) {
> +        if ((val = virTristateSwitchTypeFromString(tmp)) < 0) {
> +            virReportError(VIR_ERR_XML_ERROR, _("unknown eim value: %s"), tmp);
> +            goto cleanup;
> +        }
> +        iommu->eim = val;
> +    }

Reviewed-by: Andrea Bolognani <abologna redhat com>

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]