[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] CI: add code coverage analysis



Em 25/05/2017 05:21, Daniel P. Berrange escreveu:
On Thu, May 25, 2017 at 01:14:36AM -0300, claudioandre br gmail com wrote:
@@ -64,7 +65,8 @@ before_install:
# the custom PATH is just to pick up OS-X homebrew & its harmless on Linux
  before_script:
-  - PATH="/usr/local/opt/gettext/bin:/usr/local/opt/rpcgen/bin:$PATH" ./autogen.sh
+  - PATH="/usr/local/opt/gettext/bin:/usr/local/opt/rpcgen/bin:$PATH" ./autogen.sh "$COVERAGE"
+  - gem install coveralls-lcov
Does this actually work on OS-X ? The fact that you only enabled
testing on Trusty suggests not, and if so you shouldn't run this
in the common path.

Yes, it does work on OS-X (I tested on 10.11). I enabled only on Trusty because I prefer to use the latest LTS to it (I mean, the latest version and LTS).

That said, do you want any change?

Claudio



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]