[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 3/3] tests : Testcases for loadparm




On 05/23/2017 09:27 AM, Farhan Ali wrote:
> Add testcases for loadparm
> 
> Signed-off-by: Farhan Ali <alifm linux vnet ibm com>
> Reviewed-by: Boris Fiuczynski <fiuczy linux vnet ibm com>
> Reviewed-by: Bjoern Walk <bwalk linux vnet ibm com>
> Reviewed-by: Marc Hartmayer <mhartmay linux vnet ibm com>
> ---
>  ...-machine-loadparm-multiple-disks-nets-s390.args | 28 ++++++++++++++
>  ...v-machine-loadparm-multiple-disks-nets-s390.xml | 43 ++++++++++++++++++++++
>  .../qemuxml2argv-machine-loadparm-net-s390.args    | 20 ++++++++++
>  .../qemuxml2argv-machine-loadparm-net-s390.xml     | 26 +++++++++++++
>  ...xml2argv-machine-loadparm-s390-char-invalid.xml | 26 +++++++++++++
>  ...uxml2argv-machine-loadparm-s390-len-invalid.xml | 26 +++++++++++++
>  .../qemuxml2argv-machine-loadparm-s390.args        | 20 ++++++++++
>  .../qemuxml2argv-machine-loadparm-s390.xml         | 26 +++++++++++++
>  tests/qemuxml2argvtest.c                           | 19 ++++++++++
>  9 files changed, 234 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-char-invalid.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-len-invalid.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.xml
> 

These all seem reasonable - but could be merged with patch2 which had
the qemu changes.


John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]