[libvirt] [PATCH 1/7] node_device: Use the iterator variable

Bjoern Walk bwalk at linux.vnet.ibm.com
Fri May 26 06:50:47 UTC 2017


John Ferlan <jferlan at redhat.com> [2017-05-25, 02:37PM -0400]:
>
>
>On 05/22/2017 02:38 AM, Bjoern Walk wrote:
>> From: Marc Hartmayer <mhartmay at linux.vnet.ibm.com>
>>
>> As the switch statement checks data.type of the iterator variable @cap
>> it must use this variable for the update too.
>
>s/must/can...
>
>I can adjust the commit message before pushing though, so no need for a
>v2...
>
>>
>> Suggested-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
>> Signed-off-by: Marc Hartmayer <mhartmay at linux.vnet.ibm.com>
>> ---
>>  src/node_device/node_device_driver.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
>Reviewed-by: John Ferlan <jferlan at redhat.com>

Thanks alot.

>
>John
>
>(at least I understand why you jumped on my other series now ;-))

Yeah, kind of 'one hand washes the other' or something.

-- 
IBM Systems
Linux on z Systems & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland
Schönaicher Str. 220
71032 Böblingen
Phone: +49 7031 16 1819
E-Mail: bwalk at de.ibm.com
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 896 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170526/7becac8d/attachment-0001.sig>


More information about the libvir-list mailing list