[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 05/14] nodedev: Use common naming for virnodedeviceobj



On Thu, May 25, 2017 at 15:57:02 -0400, John Ferlan wrote:
> A virNodeDeviceObjPtr is an @obj
> 
> A virNodeDeviceObjListPtr is an @devs
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/conf/virnodedeviceobj.c | 130 ++++++++++++++++++++++----------------------
>  1 file changed, 65 insertions(+), 65 deletions(-)
> 
> diff --git a/src/conf/virnodedeviceobj.c b/src/conf/virnodedeviceobj.c
> index 913cdda..a2d09ad 100644
> --- a/src/conf/virnodedeviceobj.c
> +++ b/src/conf/virnodedeviceobj.c
> @@ -34,10 +34,10 @@ VIR_LOG_INIT("conf.virnodedeviceobj");
>  
>  
>  static int
> -virNodeDeviceObjHasCap(const virNodeDeviceObj *dev,
> +virNodeDeviceObjHasCap(const virNodeDeviceObj *obj,

I'm not a fan of this. Adds line churn and it's not really worth it.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]