[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 14/14] nodedev: Introduce virNodeDeviceObjNew



On Thu, May 25, 2017 at 15:57:11 -0400, John Ferlan wrote:
> Create an allocator for the virNodeDeviceObjPtr - include setting up
> the mutex, saving the virNodeDeviceDefPtr, and locking the return object.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/conf/virnodedeviceobj.c | 33 ++++++++++++++++++++++-----------
>  1 file changed, 22 insertions(+), 11 deletions(-)
> 
> diff --git a/src/conf/virnodedeviceobj.c b/src/conf/virnodedeviceobj.c
> index 1648b33..a84266b 100644
> --- a/src/conf/virnodedeviceobj.c
> +++ b/src/conf/virnodedeviceobj.c
> @@ -33,6 +33,27 @@
>  VIR_LOG_INIT("conf.virnodedeviceobj");
>  
>  
> +static virNodeDeviceObjPtr
> +virNodeDeviceObjNew(virNodeDeviceDefPtr *def)

Same as in previous patch. PAssing pointer to a pointer is really
overcomplicating stuff here.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]