[libvirt] [PATCH v2 11/11] interface: Alter virInterfaceObjListAssignDef @def param
John Ferlan
jferlan at redhat.com
Fri May 26 13:56:50 UTC 2017
On 05/26/2017 08:55 AM, Peter Krempa wrote:
> On Fri, May 26, 2017 at 07:59:10 -0400, John Ferlan wrote:
>> Rather than pass by value, let's pass by reference since the object ends
>> up "owning" the XML definition, let's make that ownership a bit more real.
>>
>> Signed-off-by: John Ferlan <jferlan at redhat.com>
>> ---
>> src/conf/virinterfaceobj.c | 12 +++++++-----
>> src/conf/virinterfaceobj.h | 2 +-
>> src/test/test_driver.c | 5 ++---
>> 3 files changed, 10 insertions(+), 9 deletions(-)
>
> As said in the previous series. This is introducing a lot of complexity
> tue to the double pointers and really is not very helpful in making the
> code understandable.
>
As in nodedev, I can drop this one. Dropping one at the end of these
series is a whole lot easier that one earlier when it comes to merge
conflict resolution.
John
More information about the libvir-list
mailing list