[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/7] extend node_device for CCW and fc_remote_port



  Daniel P. Berrange wrote:

> On Fri, May 26, 2017 at 07:11:53AM -0400, John Ferlan wrote:
> > 
> > 
> > On 05/26/2017 03:15 AM, Bjoern Walk wrote:
> > > Thanks a lot for your review John.
> > > 
> > > If you don't mind, you can make the adjustments you mentioned and push,
> > > as I can only prepare a v2 on Monday and I wanted to get this in v3.4.0.
> > > 
> > > Best,
> > > Bjoern
> > > 
> > 
> > I've made the adjustments and will push this sometime today...
> 
> FYI this broke the build on OS-X
> 
> 
> util/virfcp.c:85:5: error: implicit declaration of function 'virReportSystemError' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> 
>     virReportSystemError(ENOSYS, "%s", _("Not supported on this platform"));
> 
> util/virfcp.c:83:1: error: no previous prototype for function 'virSysfsIsCapableFCRport' [-Werror,-Wmissing-prototypes]
> 
> virSysfsIsCapableFCRport(const char *rport ATTRIBUTE_UNUSED)
> 
> util/virfcp.c:90:1: error: no previous prototype for function 'virSysfsReadFCRport' [-Werror,-Wmissing-prototypes]
> 
> virSysfsReadFCRport(const char *rport ATTRIBUTE_UNUSED,
> 
> 
> https://travis-ci.org/libvirt/libvirt/jobs/236407391
> 
> Regards,
> Daniel

This breaks build on FreeBSD as well. I have a fix that I plan to push
shortly.

Roman Bogorodskiy

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]