On Mon, May 29, 2017 at 02:23:39PM +0800, Chen Hanxiao wrote:
Hi, Should we remove this restriction(--maximum MUST be used with --config)? Regards, -Chen
It doesn't make much sense to remove it now. There is no hypervisor that allows that and we can remove it in the future. I'm not saying we can't remove it, but there is no point in doing that. However, if we take your approach, where --maximum implies --config, then we need to keep that promise in future versions. And, if any hypervisor adds support for changing the maximum later on, there would be no way how to call it from virsh as --maximum would have to imply --config forever. I think that's kinda what Peter was trying to say.
在2017年05月29日 13:32，Peter Krempa 写道： On Sat, May 27, 2017 at 15:14:11 +0800, Chen Hanxiao wrote:From: Chen Hanxiao <chenhanxiao gmail com> Currently --maximum was possible if and only if --config was specified. This patch makes setvcpus --maximum imply --config.NACK, some hypervisors may actually allow changing of the maximum in live config, so this would make it impossible to modify that.
-- libvir-list mailing list libvir-list redhat com https://www.redhat.com/mailman/listinfo/libvir-list
Description: Digital signature