[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] udev: Fix build on older platforms



On Wed, May 31, 2017 at 12:44:37PM +0200, Michal Privoznik wrote:
> On 05/31/2017 12:22 PM, Erik Skultety wrote:
> > Caused by commit @d1eea6c1 due to the missing symbol on older platforms.
> >
> > Signed-off-by: Erik Skultety <eskultet redhat com>
> > ---
> > Despite falling under build-breaker category, I'd like to get a proper review,
> > since I'm not really familiar with autoconf and there might be a better fix.
> >
> > Erik
> >
> >  configure.ac                       | 2 +-
> >  src/node_device/node_device_udev.c | 2 ++
> >  2 files changed, 3 insertions(+), 1 deletion(-)
>
>
> diff --git a/m4/virt-udev.m4 b/m4/virt-udev.m4
> index 85ca2cb1a..be7dba5d2 100644
> --- a/m4/virt-udev.m4
> +++ b/m4/virt-udev.m4
> @@ -34,6 +34,14 @@ AC_DEFUN([LIBVIRT_CHECK_UDEV],[
>       if test "$with_udev_logging" = "yes" ; then
>          AC_DEFINE_UNQUOTED([HAVE_UDEV_LOGGING], 1, [whether libudev logging can be used])
>       fi
> +
> +    old_CFLAGS="$CFLAGS"
> +    old_LIBS="$LIBS"
> +    CFLAGS="$CFLAGS $UDEV_CFLAGS"
> +    LIBS="$CFLAGS $UDEV_LIBS"
> +    AC_CHECK_FUNCS([udev_monitor_set_receive_buffer_size])
> +    CFLAGS="$old_CFLAGS"
> +    LIBS="$old_LIBS"
>    fi
>  ])
>
>
> This is what I wanted to say, but Daniel beat me to it. ACK if you go this way.

Thanks, help's appreciated, the fix is not pushed.

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]