[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: mkdir memory_backing_dir on startup



On Wed, May 31, 2017 at 15:17:24 +0200, Michal Privoznik wrote:
> On 05/31/2017 03:00 PM, Andrea Bolognani wrote:
> > On Sat, 2017-05-27 at 12:45 +0200, Michal Privoznik wrote:
> >> In 48d9e6cdcc and friends we've allowed users to back guest
> >> memory by a file inside the host. And in order to keep things
> >> manageable the memory_backing_dir variable was introduced to
> >> qemu.conf to specify the directory where the files are kept.
> >> However, libvirt's policy is that directories are created on
> >> domain startup if they don't exist. We've missed this one.
> >>  
> >> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> >> ---
> >>   src/qemu/qemu_driver.c | 12 ++++++++++++
> >>   1 file changed, 12 insertions(+)
> > 
> > ACK and safe for freeze.
> > 
> > Wouldn't mind it if you provided a very brief entry in the
> > release notes, too ;)
> > 
> 
> Ah, good point. Keep forgetting about those. Fixed and pushed. Thanks!

Please note that we've explicitly stated that changes to the news.xml
file should be in separate patches, which you've ignored.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]