[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 1/2] virDomainXMLOption: Introduce virDomainABIStabilityDomain



On Fri, May 26, 2017 at 11:58:44 +0200, Michal Privoznik wrote:
> While checking for ABI stability, drivers might pose additional
> checks that are not valid for general case. For instance, qemu
> driver might check some memory backing attributes because of how
> qemu works. But those attributes may work well in other drivers.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/conf/domain_conf.c        | 19 ++++++++++++++++---
>  src/conf/domain_conf.h        | 16 ++++++++++++++--
>  src/conf/snapshot_conf.c      |  3 ++-
>  src/conf/snapshot_conf.h      |  1 +
>  src/libxl/libxl_conf.c        |  2 +-
>  src/libxl/libxl_domain.c      |  4 +++-
>  src/lxc/lxc_conf.c            |  3 ++-
>  src/openvz/openvz_driver.c    |  2 +-
>  src/phyp/phyp_driver.c        |  2 +-
>  src/qemu/qemu_capabilities.c  |  2 +-
>  src/qemu/qemu_conf.c          |  3 ++-
>  src/qemu/qemu_domain.c        |  1 +
>  src/qemu/qemu_driver.c        |  5 +++--
>  src/security/virt-aa-helper.c |  2 +-
>  src/test/test_driver.c        |  6 ++++--
>  src/uml/uml_driver.c          |  2 +-
>  src/vbox/vbox_common.c        |  2 +-
>  src/vmware/vmware_driver.c    |  2 +-
>  src/vmx/vmx.c                 |  2 +-
>  src/vz/vz_driver.c            |  2 +-
>  src/xen/xen_driver.c          |  2 +-
>  src/xenapi/xenapi_driver.c    |  2 +-
>  tests/bhyveargv2xmltest.c     |  3 ++-
>  tests/qemuargv2xmltest.c      |  2 +-
>  tests/qemuxml2argvtest.c      |  2 +-
>  tests/sexpr2xmltest.c         |  2 +-
>  tests/testutils.c             |  4 ++--
>  tests/vmx2xmltest.c           |  2 +-
>  tests/xlconfigtest.c          |  2 +-
>  tests/xmconfigtest.c          |  2 +-
>  tests/xml2sexprtest.c         |  2 +-
>  tests/xml2vmxtest.c           |  2 +-
>  32 files changed, 72 insertions(+), 36 deletions(-)

[...]

> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index 83e067269..446b117b7 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -2537,9 +2537,19 @@ struct _virDomainXMLPrivateDataCallbacks {
>      virDomainXMLPrivateDataParseFunc  parse;
>  };
>  

Could you please document the expected return value meanings here.

> +typedef bool (*virDomainABIStabilityDomain)(const virDomainDef *src,
> +                                            const virDomainDef *dst);
> +
> +typedef struct _virDomainABIStability virDomainABIStability;
> +typedef virDomainABIStability *virDomainABIStabilityPtr;
> +struct _virDomainABIStability {
> +    virDomainABIStabilityDomain domain;
> +};

ACK

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]