[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release



On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote:
On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan redhat com>
---
I could not be bothered to split the patches.  Also, please review
whatever you know about as this is just a compilation of stuff from
the git log.

 docs/news.xml | 166 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 165 insertions(+), 1 deletion(-)

diff --git a/docs/news.xml b/docs/news.xml
index 649350a904d3..d34e8beae4c0 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -45,6 +45,38 @@

[...]

+      <change>
+        <summary>
+          Repository now has new README.md file
+        </summary>
+        <description>
+          The new file uses markdown syntax, so it looks better on
+          github and possibly other web pages, but it has also more
+          useful information.  The old README is now symlink to the
+          new file.
+        </description>
+      </change>

This does not seem to be a feature to me in any possible way.


I probably wanted to put it in Improvements, can that be?

@@ -67,10 +99,142 @@

[...]

+      <change>
+        <summary>
+          libxl: NUMA sibling distances are now reported in host capabilities
+        </summary>
+      </change>
+      <change>
+        <summary>
+          Support for VMDK files with version 3
+        </summary>
+        <description>
+          VMDK version 3 files are now properly detected.

Was this description suggested by the department of redundancy
department?


I'll go with just "VMDK version 3 files are now properly detected" as a summary.


+        </description>
+      </change>
+      <change>
+        <summary>
+          Interrupt remapping and Extended interrupt mode for IOMMU devices
+        </summary>
+        <description>
+          These two new features can now be controlled with new
+          <code>&lt;driver intremap='on/off' eim='on/off'/&gt;</code>
+          tag for <code>iommu</code> devices.
+        </description>
+      </change>

Why was the other iommu change considered a feature and this is an
improvement?


What other iommu change?  I can't find any in this file.


ACK to everything excepthe readme.md section.

Please, reconsider with this squashed in, since there was off-list reply
with double spaces as well:

diff --git i/docs/news.xml w/docs/news.xml
index d34e8beae4c0..b351f22990a1 100644
--- i/docs/news.xml
+++ w/docs/news.xml
@@ -57,17 +57,6 @@
      </change>
      <change>
        <summary>
-          Repository now has new README.md file
-        </summary>
-        <description>
-          The new file uses markdown syntax, so it looks better on
-          github and possibly other web pages, but it has also more
-          useful information.  The old README is now symlink to the
-          new file.
-        </description>
-      </change>
-      <change>
-        <summary>
          The reason for VM shutdown is reported, if known
        </summary>
        <description>
@@ -81,6 +70,17 @@
    <section title="Improvements">
      <change>
        <summary>
+          Repository now has new README.md file
+        </summary>
+        <description>
+          The new file uses markdown syntax, so it looks better on
+          github and possibly other web pages, but it has also more
+          useful information. The old README is now symlink to the
+          new file.
+        </description>
+      </change>
+      <change>
+        <summary>
          qemu: Use GICv2 by default for aarch64/virt TCG guests
        </summary>
        <description>
@@ -117,7 +117,7 @@
        </summary>
        <description>
          If supported in the kernel, host capabilities will now list
-          L3 caches.  The code for other levels was added as well, but
+          L3 caches. The code for other levels was added as well, but
          only L3 caches are reported currently.
        </description>
      </change>
@@ -136,11 +136,8 @@
      </change>
      <change>
        <summary>
-          Support for VMDK files with version 3
+          VMDK version 3 files are now properly detected
        </summary>
-        <description>
-          VMDK version 3 files are now properly detected.
-        </description>
      </change>
      <change>
        <summary>
@@ -158,7 +155,7 @@
        </summary>
        <description>
          Even though there were default addresses before this change,
-          they were not saved in the XML.  It is now possible to see
+          they were not saved in the XML. It is now possible to see
          and control the listen addresses properly.
        </description>
      </change>
@@ -169,7 +166,7 @@
        <description>
          Even though they were added automatically when USB device
          was attached, they could've been missing in some other
-          cases.  The logic is now fixed so there are always USB
+          cases. The logic is now fixed so there are always USB
          controllers, even if there was none of them in the specified
          XML.
        </description>
@@ -181,7 +178,7 @@
        <description>
          Hitting the RPC limits we have is easier every day, so they
          were increased once again and some guessing logic was
-          improved as well.  It is now possible to get more stats than
+          improved as well. It is now possible to get more stats than
          ever using the <code>virConnectGetAllDomainStats()</code>
          call and push through even bigger requests and replies for
          all APIs.
@@ -195,7 +192,7 @@
        </summary>
        <description>
          It could happen that the link speed for PCIe devices was not
-          properly reported or the nodedev-dumpxml just failed.  That
+          properly reported or the nodedev-dumpxml just failed. That
          was due to mistake in the field width, but should now work
          properly.
        </description>
@@ -219,7 +216,7 @@
        <description>
          It could happen, in some cases, that libvirt would mistake a
          user-specified path for its own generated one and thus
-          remove it from the XML.  The detection of such addresses was
+          remove it from the XML. The detection of such addresses was
          improved now.
        </description>
      </change>
@@ -407,7 +404,7 @@
          NVDIMM is new type of memory introduced into QEMU 2.6. The idea is
          that we have a non-volatile memory module that keeps the data
          persistent across domain reboots and offers much faster data
-          accesses.  However, due to a bug in QEMU, this feature is not enabled
+          accesses. However, due to a bug in QEMU, this feature is not enabled
          for QEMUs older than 2.9.0.
        </description>
      </change>
--

Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]