[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release



On Wed, May 31, 2017 at 17:35:52 +0200, Martin Kletzander wrote:
> On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote:
> > On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote:
> > > Signed-off-by: Martin Kletzander <mkletzan redhat com>
> > > ---
> > > I could not be bothered to split the patches.  Also, please review
> > > whatever you know about as this is just a compilation of stuff from
> > > the git log.
> > > 
> > >  docs/news.xml | 166 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > >  1 file changed, 165 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/docs/news.xml b/docs/news.xml
> > > index 649350a904d3..d34e8beae4c0 100644
> > > --- a/docs/news.xml
> > > +++ b/docs/news.xml
> > > @@ -45,6 +45,38 @@
> > 
> > [...]
> > 
> > > +      <change>
> > > +        <summary>
> > > +          Repository now has new README.md file
> > > +        </summary>
> > > +        <description>
> > > +          The new file uses markdown syntax, so it looks better on
> > > +          github and possibly other web pages, but it has also more
> > > +          useful information.  The old README is now symlink to the
> > > +          new file.
> > > +        </description>
> > > +      </change>
> > 
> > This does not seem to be a feature to me in any possible way.
> > 
> 
> I probably wanted to put it in Improvements, can that be?

I don't feel that adding that file improved anything, but yes, that is
the more appropriate place.

> 
> > > @@ -67,10 +99,142 @@
> > 
> > [...]
> > 
> > > +      <change>
> > > +        <summary>
> > > +          libxl: NUMA sibling distances are now reported in host capabilities
> > > +        </summary>
> > > +      </change>
> > > +      <change>
> > > +        <summary>
> > > +          Support for VMDK files with version 3
> > > +        </summary>
> > > +        <description>
> > > +          VMDK version 3 files are now properly detected.
> > 
> > Was this description suggested by the department of redundancy
> > department?
> > 
> 
> I'll go with just "VMDK version 3 files are now properly detected" as a summary.

That's exactly what I've meant :)

> 
> 
> > > +        </description>
> > > +      </change>
> > > +      <change>
> > > +        <summary>
> > > +          Interrupt remapping and Extended interrupt mode for IOMMU devices
> > > +        </summary>
> > > +        <description>
> > > +          These two new features can now be controlled with new
> > > +          <code>&lt;driver intremap='on/off' eim='on/off'/&gt;</code>
> > > +          tag for <code>iommu</code> devices.
> > > +        </description>
> > > +      </change>
> > 
> > Why was the other iommu change considered a feature and this is an
> > improvement?
> > 
> 
> What other iommu change?  I can't find any in this file.


> 
> > 
> > ACK to everything excepthe readme.md section.

ACK

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]