[libvirt] [PATCH] conf: Don't inline virDomainNetTypeSharesHostView

Ján Tomko jtomko at redhat.com
Fri Nov 3 12:40:00 UTC 2017


On Thu, Nov 02, 2017 at 09:03:15PM +0100, Jiri Denemark wrote:
>When coverage build is enabled, gcc complains about it:
>
>In file included from qemu/qemu_agent.h:29:0,
>                 from qemu/qemu_driver.c:47:
>qemu/qemu_driver.c: In function 'qemuDomainSetInterfaceParameters':
>./conf/domain_conf.h:3397:1: error: inlining failed in call to
>'virDomainNetTypeSharesHostView': call is unlikely and code size would
>grow [-Werror=inline]
> virDomainNetTypeSharesHostView(const virDomainNetDef *net)
> ^
>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---

ACK

>
>Notes:
>    Shouldn't we just kill all (or most of) our worthless usage of the
>    inline keyword?

shrug

>
> src/conf/domain_conf.c   | 36 ++++++++++++++++++++++++++++++++++++
> src/conf/domain_conf.h   | 37 +++----------------------------------
> src/libvirt_private.syms |  1 +
> 3 files changed, 40 insertions(+), 34 deletions(-)

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171103/906ed168/attachment-0001.sig>


More information about the libvir-list mailing list