[libvirt] [PATCH v2 04/15] vbox: vboxAttachDrives now relies on address info
John Ferlan
jferlan at redhat.com
Fri Nov 3 13:42:07 UTC 2017
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> Previously, the driver was computing VBOX's devicePort/deviceSlot values
> based on device name and max port/slot values. While this worked, it
> completely ignored <address> values. Additionally, libvirt's built-in
> virDomainDiskDefAssignAddress already does a good job setting default
> values on virDomainDeviceDriveAddress struct which we can use to set
> devicePort and deviceSlot and accomplish the same result while allowing
> the cusomizing those via XML. Also, this allows to remove some code
customizing
> which will make further patches smaller.
> ---
> src/vbox/vbox_common.c | 104 ++++---------------------------------------------
> 1 file changed, 7 insertions(+), 97 deletions(-)
>
Reviewed-by: John Ferlan <jferlan at redhat.com>
John
More information about the libvir-list
mailing list