[libvirt] Interim fix for exposing VMware firmware=bios|efi in libvirt XML

[Daniel P. Berrange]

On Tue, Nov 07, 2017 at 09:09:07AM +0000, Richard W.M. Jones wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1217444
> 
> VMware guests can use either BIOS or UEFI firmware.  VMware itself
> exposes this information in the VMX file and it's available to the ESX
> driver in libvirt.  virt-v2v wants to consume this information.
> 
> Unfortunately after a few years and iterations we've not come up with
> an acceptable patch to expose “has UEFI” in the libvirt XML.  (Latest
> patch was:
> https://www.redhat.com/archives/libvir-list/2016-October/msg00045.html )
> 
> Could we instead add a temporary addition to the XML generated by the
> ESX driver?  I'm thinking something like the existing <vmware:moref>
> and <vmware:datacenterpath> fields:
> 
> <domain type='vmware' xmlns:vmware='http://libvirt.org/schemas/domain/vmware/1.0'>
>   <name>Fedora</name>
> ...
>   <vmware:datacenterpath>ha-datacenter</vmware:datacenterpath>
>   <vmware:moref>2</vmware:moref>
>   <vmware:firmware>uefi</vmware:firmware>  <!-- "bios" or "uefi" -->
> </domain>
> 
> This field would be informational, ie. the ESX driver would create it
> but not read it when creating new VMs.
> 
> This would solve our immediate problem in virt-v2v and is pretty
> simple to implement.  Also it doesn't close off any future general
> solution.

I don't see a need todo that. The problems with the patch I sent previously
were all in the QEMU driver support for it. We can easily merge the XML
config bit (my patch #2), and then do an ESX impl, and figure out QEMU impl
later.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|